-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new packages: JACK Audio Connection Kit and alsa-lib
#20544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, exciting work! I think we can drop BUILD_DEPENDS on jack2 for mpv, otherwise looks good!
008d61e
to
5f16015
Compare
Refactored to remove ANTI_BUILD_DEPENDS, added few utils pacakges and added 0004 patch to There are quite some issues in
|
Thanks! Exciting work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this reinstates support for alsa-utils
I have removed it from disabled-packages in 7a1f71a.
Please check that volume_mapping.c.patch
is not still applicable to the reinstated version.
--- ./alsamixer/volume_mapping.c 2016-08-02 22:39:45.000000000 +0530 | |
+++ ../volume_mapping.c 2016-12-03 23:15:26.390744307 +0530 | |
@@ -37,7 +37,7 @@ | |
#include <stdbool.h> | |
#include "volume_mapping.h" | |
-#ifdef __UCLIBC__ | |
+#if defined(__UCLIBC__) || defined(__ANDROID__) | |
/* 10^x = 10^(log e^x) = (e^x)^log10 = e^(x * log 10) */ | |
#define exp10(x) (exp((x) * log(10))) | |
#endif /* __UCLIBC__ */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no #define exp10(x) and no use of exp10 in the current version of alsa-utils.
Few packages
jack2
is an audio server. On Android, it can use OpenSLES as backend.jack
is for dependency management and will accept the upcomingpipewire-jack
as an option. By the way, I am not interested in makingjack1
functional and be one of thejack
option, given that we havejack2
now and it seems Linux distros usually not packingjack1
officially (at least for Archlinux it is in AUR).alsa-lib
as deps ofjack2
. Also, it is tested to work along withpipewire-alsa
which will be finalized in the pipewire PR.mpv
andmpv-x
are updated to support jack and alsa audio outputTested working with:
and then use the updated mpv in this PR
By the way, since #20353 also use jack (which I put a stub and useless jack1), I will refactor that PR after this is merged.