Move the signing keys info for each repo channel to repo json file #21181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the signing keys info for each repo channel to
repo.json
instead of hardcoding it in build scriptsThis will allow each repo channel to define its own keys that may be used for verifying signatures of its files. The
termux-packages
fork will just need to add signing keys info in therepo.json
file itself for any additional channels instead of having to patch build scripts. With the old hardcoded way, the unnecessary pacman key was also being added to local keystore in the current/upstream termux-packages repo, even though no repo channel uses it, so defining the keys in therepo.json
will solve that issue as well.The
termux_repository__add_repo_signing_keys_to_keystore()
function now handles the logic for adding the repository signing keys to the local keystore. Check its function docs for more info on the new json format and requirements forrepo.json
file.packages/termux-keyring/termux-pacman.gpg
to each repository channel.