libpaper: remove _NL_PAPER_{WIDTH,HEIGHT}

[knyipab]

Discovered that _NL_PAPER_WIDTH and _NL_PAPER_HEIGHT are not the size but they are C++ enum items (e.g. defined in langinfo.h) that is the input of std c lib func nl_langinfo() . Feeding 210 and 297 into that func may have unknown behavior.

I discovered this as I am trying to build libreoffice and I encountered the similar issue in their paper.cxx.

It may not have material impact on existing package, but just for correctness.

[Biswa96]

Discovered that _NL_PAPER_WIDTH and _NL_PAPER_HEIGHT are not the size but they are C++ enum items

That explains the removal of CFLAGS+=" -D_NL_PAPER_WIDTH=210 -D_NL_PAPER_HEIGHT=297" 👍

Could you explain why the patch file was added?

[knyipab]

Cuz android's bionic (langinfo.h) never define or provide _NL_PAPER_WIDTH and _NL_PAPER_HEIGHT at all, so there is no such thing nl_langinfo(_NL_PAPER_WIDTH). Libreoffice's paper.cxx basically skip that part of locale paper size detection with && !defined(ANDROID). See:
https://github.com/LibreOffice/core/blob/7db1150b2c4a9adb993084d2dceedb450781b1dc/i18nutil/source/utility/paper.cxx#L308-L317

Note; libreoffice's ANDROID is probably configured by their makefile and does not work, so I patch that to !defined(__ANDROID__)

[Biswa96]

Thanks for the explanation. I think this change can be added in upstream.

__ANDROID__ is the correct one https://android.googlesource.com/platform/bionic/+/HEAD/docs/defines.md

[knyipab]

Okay, made one here: rrthomas/libpaper#59
Last commit is six months ago and will see if they will merge and make a new release.

[landfillbaby]

alternatively, partially revert 2148a3e, to this:

termux_step_pre_configure() {
	# 210x297 is A4 size. Hard code as default.
	sed -i \
		-e "s|NL_PAPER_GET(_NL_PAPER_WIDTH)|210|g" \
		-e "s|NL_PAPER_GET(_NL_PAPER_HEIGHT)|297|g" \
		"${TERMUX_PKG_SRCDIR}"/lib/libpaper.c.in.in
}

or write an equivalent patch

[knyipab]

I do not hold strong view nor any preference on which approach. I just want to flag it. Feel free to change this PR.

[twaik]

Tuxpaint works fine, no errors.

[twaik]

I'll push these changes in 48 hours if no one minds.
Or someone else can do that earlier.

[knyipab]

I am open to any decisions (merge or not).

Just FYI, the author has updated the master branch to handle this issue and ask for test. But I did not figure out a way to build the it from the git branch which needs to run ./bootstrap. Therefore, I did not get back to confirm the author for quite a while.

• This commit: knyipab@d071aff
• This action build: https://github.com/knyipab/termux-packages/actions/runs/10997204713