-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Addition of Amazon S3 Event Notifications #245
Open
schniber
wants to merge
9
commits into
terraform-aws-modules:master
Choose a base branch
from
schniber:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+385
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @bryantbiggs ! Happy new year 2025 ! with all my best wishes of success ! |
bryantbiggs
reviewed
Jan 6, 2025
bryantbiggs
reviewed
Jan 6, 2025
bryantbiggs
reviewed
Jan 6, 2025
bryantbiggs
reviewed
Jan 6, 2025
bryantbiggs
reviewed
Jan 6, 2025
schniber
changed the title
feat: Upgrade of runtime to Python3.12 & Addition of Amazon S3 Event Notifications
feat: Addition of Amazon S3 Event Notifications
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at fixing #244 and adds the support of Amazon S3 Event Notifications through the Slack Lambda function.
Motivation and Context
This PR aims at fixing #244
Breaking Changes
No Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request