Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Settings Validators should be in the setting package #1464

Closed
john-science opened this issue Nov 8, 2023 · 1 comment
Closed

The Settings Validators should be in the setting package #1464

john-science opened this issue Nov 8, 2023 · 1 comment
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority

Comments

@john-science
Copy link
Member

Right now, the settings validation tools are in the operator package, which is just strange:

armi/armi/operators/settingsValidation.py

Line 44 in 6a546dd

class Query:

But, we have a whole PACKAGE for settings. Surely this belongs there?

NOTE: This should be doable without breaking the API, by just putting a couple imports in the operator __init__.
@john-science john-science added architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority labels Nov 8, 2023
@keckler keckler mentioned this issue Sep 24, 2024
Open
@john-science
Copy link
Member Author

Closing in favor of: #1880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@john-science