Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is settingsValidation under operators? #1880

Open
john-science opened this issue Sep 15, 2024 · 3 comments
Open

Why is settingsValidation under operators? #1880

john-science opened this issue Sep 15, 2024 · 3 comments
Assignees
@john-science
Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority

Comments

@john-science
Copy link
Member

john-science commented Sep 15, 2024 •
edited
Loading

The tools we use to validate settings come from th Query class, which is in settingsValidation.py.

But that file is at: armi/operators/settingsValidation.py, for some reason.

Surely that should be under armi/settings/, right?
@john-science john-science added architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority labels Sep 15, 2024
@john-science john-science changed the title Why are settings validators under operators? Why is settingsValidation under operators? Sep 17, 2024
@john-science john-science self-assigned this Sep 17, 2024
@john-science
Copy link
Member Author

Ouch. I just checked, and this API-breaking import is used widely downstream.

So, to provide a more stable API, this change will have to first involve a DeprecationWarning, and then a very long intermediate period before the change is made final.

@john-science john-science mentioned this issue Sep 18, 2024
Merged
7 tasks
@keckler
Copy link
Member

keckler commented Sep 24, 2024

Seems duplicate of #1464 , no?

@john-science
Copy link
Member Author

Seems duplicate of #1464 , no?

You're right! Thanks!

@john-science john-science mentioned this issue Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@john-science john-science

Labels
architecture Issues related to big picture system architecture cleanup Code/comment cleanup: Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@john-science @keckler