-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use clearer input syntax for hexagonal lattice pitch #1654
Open
mgjarrett
wants to merge
14
commits into
terrapower:main
Choose a base branch
from
mgjarrett:hexPitch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
58d5706
Add hex attribute to lattice pitch.
mgjarrett 92a3d8e
Fix hex pitch property.
mgjarrett 89336dd
Add docstring.
mgjarrett 3109298
Add unit test for hexGrid pitch property.
mgjarrett f88d936
Add unit test for gridBlueprints.
mgjarrett 99a8c5d
Address linting errors.
mgjarrett 37e1fff
Change assertEqual to assertAlmostEqual for pitch
mgjarrett f83297a
Use x pitch if hex is not available.
mgjarrett 9837a28
Revert "Change assertEqual to assertAlmostEqual for pitch"
mgjarrett b43cffa
Revert "Add unit test for hexGrid pitch property."
mgjarrett 80a275a
Revert "Fix hex pitch property."
mgjarrett 0e07618
Merge branch 'main' into hexPitch
mgjarrett 86b2468
Fix an error in merge conflict resolution
mgjarrett 60e6c9e
Merge branch 'main' into hexPitch
mgjarrett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking it would be nice to show that this works for corners up and flats up.
I was think you could copy/paste this test, and just search/replace
"geom: hex_corners_up"
with"geom: hex
.Thoughts?