Starting the armi.testing modules #2028
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
Here I am starting the
armi.testing
module.Basically, I just move
loadTestReactor()
fromarmi.reactor.test.test_reactor
toarmi.testing
.Why is the change being made?
Right now, every single ARMI unit test is importable as part of the API. But that can't last forever. ARMI 1.0.0 will have a more usual API, without less importable noise.
A better paradigm to follow would be
numpy
. The NumPy team does not let you import their unit tests, that's madness.Instead, they provide
import numpy.testing
, which houses a small set of high-quality testing utilities for people to use when testing NumPy-based code. So, we will follow NumPy's example.progress on #1867
Checklist
doc
folder.pyproject.toml
.