Force plotAssemblyTypes to always use instantiated assemblies, and al… #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am relatively sure that this is working now. I tested it with a simply dummy case, however I am unable to test it with my big model due to some dependency conflicts. I think it is ready for your eyes @john-science |
|
Love it!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to improve #1998 by allowing the specification of hot versus cold heights in the plots. Additionally, a couple clean ups are implemented:
plotAssemblyTypes()so that it always operates based on instantiated assemblies. Allowing users to pass in blueprints was making things really messy, and provided absolutely no benefit because blueprints already containAssemblyobjects in the first place throughblueprints.assemblies.values().plotAssemblyTypes()method signature is changed. That signature is/was pretty ridiculous anyways, so I feel justified in changing it. I updated all calls to that method that I could find.I would not expect that there are many downstream calls to this
plotAssemblyTypes()method. Checking all the projects that I have access to, I found it used in exactly one place (one of my own internal repos).