Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactivity swing #2035

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

reactivity swing #2035

wants to merge 3 commits into from

Conversation

onufer
Copy link
Member

@onufer onufer commented Dec 13, 2024

What is the change?

Stop checking if its the last node since this often breaks for snapshots and just calcualte reactivity swing at all nodes
see #2034

Why is the change being made?

see above ticket


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@onufer onufer requested a review from mgjarrett December 13, 2024 20:21
@@ -9,6 +9,7 @@ Release Date: TBD
New Features
------------
#. Move instead of copy files from TemporaryDirectoryChanger. (`PR#2022 <https://github.com/terrapower/armi/pull/2022>`_)
#. `rXSwing`` is now calculated for all time nodes making snapshots less failure prone due to non-relevant inputs. (`PR#2035 <https://github.com/terrapower/armi/pull/2035>`_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARMI 0.5.0 was released.

Can we move this up in this file to the 0.5.1 release notes?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants