Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updates #5

Merged
merged 5 commits into from
Dec 19, 2022
Merged

ci: Updates #5

merged 5 commits into from
Dec 19, 2022

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 19, 2022

No description provided.

.gitignore Outdated Show resolved Hide resolved
Autocompleting ci.sh is annoying as it always matches the CI folder
instead.
Copy link
Contributor

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the deviation from others? (that use Makefile)

make.sh Show resolved Hide resolved
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 19, 2022

@alixander Make sucks, this uses my make style job.sh library. It has much better targeting of jobs with a go style regex. Please see the PR I made here terrastruct/text-to-diagram-site#33 for specific examples of its use.

And you can better control output when a job doesn't need to run whereas with make it involves setting an environment variable in make.sh before running the Makefile. See https://github.com/terrastruct/src/blob/master/make.sh#L14

As well, see bin/fmt.sh in the CI repo for how much cleaner it makes things. See terrastruct/ci@37d4202. Compare to the the code it replaced.

@nhooyr nhooyr merged commit 49b4edf into master Dec 19, 2022
@nhooyr nhooyr deleted the ciupdate-b989 branch December 19, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants