-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Subset fonts by fontstyle #1248
base: master
Are you sure you want to change the base?
wip: Subset fonts by fontstyle #1248
Conversation
below is the overall idea of this pr: |
26b9cd2
to
98a7b5e
Compare
@alixander i asked you some questions in the related issue but got no responses... anyway, no worries i draft this pr, can you help to take a glimpse, so i can know if i'm on the right direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alixander for this script:
i notice that for the generated diagram, text Line 571 in b08431b
but inside the output svg, class |
@donglixiaoche ah, yeah i think that is a bug. it just didn't affect anything because Class has its own renderer that ignored the value set on d2target: Line 14 in 91beb8d
|
@alixander but basically we add do you think i need fix this bug here? |
yes, i think it was just an innocuous bug until now, but this method will require that bugfix |
#1107
this pr helps reduce more font size of diagram