-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d2ir: Single Level Ampersand Filters #1509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
force-pushed
the
filters
branch
3 times, most recently
from
July 29, 2023 23:55
710c46e
to
eb6aa52
Compare
note: I personally wish to change the language and make it case sensitive.
In fact I don't think we want to have composite filters anyhow. I think single field filters are easier to read and much easier to implement. For example for composite filters we'd have to error if the filter itself had ampersand filters because that wouldn't make sense. |
nhooyr
force-pushed
the
filters
branch
2 times, most recently
from
July 30, 2023 08:16
be59fa5
to
e85d9e8
Compare
Were identified from @alixander writing documentation.
alixander
requested changes
Jul 30, 2023
alixander
approved these changes
Jul 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1479 being merged.
I didn't implement recursive filters in this PR. i.e you can't do something like:
You have to do the following instead: