feature: supports link on connections #1955
Conversation
There was a problem hiding this comment.
I'm not sure what adding an empty <a> tag does. There's nothing for users to click and no indication it's clickable.
I was imagining something like this: link on the connection makes the label a hyperlink. So google here would be underlined and be in link-style blue (or purple if clicked). If there's a link and no label, the link becomes the label.
|
Oh I see what you mean. I was trying to figure out how exactly you wanted it implemented so I decided to do this for now and get a review. I'll work on it |
|
Was this more what you were thinking? |
d2graph/d2graph.go
Outdated
| if edge.Link != nil { | ||
| g.Edges[i].Label.Value = edge.Link.Value | ||
| } |
There was a problem hiding this comment.
this shouldn't be in this function named set dimensions. probably in compiler.go.
Also the link shouldn't replace the label if there is one. The test should show an example of where the link turns the label into a hyperlink
There was a problem hiding this comment.
oh also i think it's a security issue if the edge label is a URL and the edge link is a URL and they are not the same URL. can you make that a compiler error and add a test for it please? (i'm pretty sure we do this for tooltips and links or something already)
|
Hi, what's the status on this PR? |
|
Oops I did not realize the ball was in my court for reviewing. Sorry @danielsuh05 . I'm not sure if you've moved on. No worries if so I can take over, otherwise will leave a review ASAP |
|
I hope to see this soon. Links on connections are pretty important. They open up a lot of possibilities for letting diagrams act as jump points to, e.g., code. |
|
I'm ok continuing with this issue. |
|
Thank you @danielsuh05 and @alixander! |
danielsuh05
force-pushed
the
issue1827
branch
from
446eb96
to
ce752d4
Compare
danielsuh05
force-pushed
the
issue1827
branch
from
ce752d4
to
92ea220
Compare
| }, | ||
| { | ||
| name: "url_link_and_path_url_label_ok", | ||
| text: `x -> y note: {link: https://not-google.com}`, |
There was a problem hiding this comment.
the colon is not in the right place, should be x -> y: note {...}
| }, | ||
| { | ||
| name: "url_link_and_path_url_label_concurrently", | ||
| text: `x -> y: hello world {link: https://google.com}`, |
There was a problem hiding this comment.
this is the same test as above?
|
|
||
| fmt.Fprintf(writer, `<a href="%s" xlink:href="%[1]s">`, svg.EscapeText(connection.Link)) | ||
| } else { | ||
| textEl.Fill = connection.GetFontColor() |
Connections now support
link:(fixes issue #1827)Some notes:
link: "".link-on-connectionsfor the test I used.