Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: link icon on shapes can now be custom #1961

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

danielsuh05
Copy link
Contributor

Fixes Issue #1828

I didn't format the option like the issue said (link.icon) because I was a bit confused by compositeReservedKeyword and some of the other things in compile.go. If you want it to be like the issue said instead of how I did it, I can look back again.

Screenshot 2024-06-01 at 16 59 35

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it should still be circular, like the plain link icon. please use a circular svg as the test example too (github has one)
  2. yes, it needs to be link.icon. it allows for further expansion down the road if needed, instead of flattening out into a bunch of new keywords. related: Container Icon in one of the corner #1653 (comment)

@danielsuh05
Copy link
Contributor Author

danielsuh05 commented Jun 3, 2024

So you want something like this?

x: hello {
    link: https://github.com {
        icon: https://github.com/_____.svg
    }
}

@alixander
Copy link
Collaborator

@danielsuh05 Yup.

Add a test for that, but also one for the flat structure

x: {
  link: https://github.com
  link.icon: https://github.com/_____.svg
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants