Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds XYZ Serializer #1531

Merged
merged 1 commit into from
Nov 7, 2024
Merged

feat: adds XYZ Serializer #1531

merged 1 commit into from
Nov 7, 2024

Conversation

faouziH21
Copy link
Contributor

This PR depends on: bb9a6cb

Copy link
Member

@LukasLohoff LukasLohoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the MapFishPrintV3StamenSerializer as well?

Copy link

github-actions bot commented May 10, 2024

null

dnlkoch
dnlkoch previously approved these changes May 14, 2024
@dnlkoch dnlkoch dismissed their stale review May 17, 2024 07:52

Missing XYZ Serializer

@faouziH21
Copy link
Contributor Author

Due to a version conflict this branch cannot be merged. MapFishPrint requires OpenLayers version 9 while the SHOgun gis-client is still running OpenLayers version 7.5.2.

@dnlkoch dnlkoch changed the base branch from main to next November 6, 2024 12:14
@dnlkoch
Copy link
Member

dnlkoch commented Nov 7, 2024

Branch has been rebased against the current next branch and besides the added serializers it:

  • fixes a console warning about the unused form instance
  • renames initializeMapProvider to initializePrintManager

Please review again @terrestris/devs.

@dnlkoch
Copy link
Member

dnlkoch commented Nov 7, 2024

Thanks for the review!

@dnlkoch dnlkoch merged commit 02c71a6 into next Nov 7, 2024
1 check passed
@dnlkoch dnlkoch deleted the add-XYZ-Serializer branch November 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants