Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charging_state to VehicleSummary #3087

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Add charging_state to VehicleSummary #3087

merged 1 commit into from
Nov 16, 2023

Conversation

brianmay
Copy link
Collaborator

Fixes: #3078

This will publish the state to MQTT and allow sensing of the NoPower state.

@brianmay
Copy link
Collaborator Author

Notes:

  1. Not tested yet. About to do that.
  2. Wondering if I should add to @always_published which will publish nil values. But most likely reason for nil value is because vehicle.charge_state is nil, which means we don't know this value just yet, which means we shouldn't publish.

Actually thinking we shouldn't publish any vehicle.charge_state values if that value is nil, because it does mean we don't know what the value is. But fixing this beyond the scope of this simple pull request.

@brianmay
Copy link
Collaborator Author

As far as I can tell the CI test failures are unrelated.

@brianmay
Copy link
Collaborator Author

Preliminary testing seems to indicate it is working...

@brianmay brianmay marked this pull request as ready for review January 25, 2023 23:14
brianmay added a commit to brianmay/robotica-rust that referenced this pull request Mar 9, 2023
@brianmay
Process Tesla Mate charing state events
3633cc3 
Requires teslamate-org/teslamate#3087
@brianmay brianmay mentioned this pull request May 19, 2023
Closed
@brianmay brianmay mentioned this pull request Nov 12, 2023
Closed
@JakobLichterfeld
Copy link
Collaborator

  1. Not tested yet. About to do that.

Did you test it in the meantime?

@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Nov 16, 2023
@brianmay
Copy link
Collaborator Author

Yes, is tested and working. I see there is a conflict, will try to resolve that.

@brianmay
Copy link
Collaborator Author

I rebased this against the latest master.

@brianmay
Copy link
Collaborator Author

brianmay commented Nov 16, 2023 •
edited
Loading

I think the test errors are not connected to this PR.

JakobLichterfeld
JakobLichterfeld approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, failed CI is handled in #3428

@DrMichael DrMichael merged commit 6d0405d into teslamate-org:master Nov 16, 2023
1 of 2 checks passed
@JakobLichterfeld JakobLichterfeld mentioned this pull request Nov 20, 2023
Closed
1 task
JakobLichterfeld added a commit that referenced this pull request Nov 20, 2023
@JakobLichterfeld
Revert "Add charging_state to VehicleSummary (#3087)"
e61bdd6 
This reverts commit 6d0405d.
@JakobLichterfeld JakobLichterfeld mentioned this pull request Nov 20, 2023
Merged
JakobLichterfeld added a commit that referenced this pull request Nov 20, 2023
@JakobLichterfeld
Revert "Add charging_state to VehicleSummary (#3087)" (#3468)
b03783b 
This reverts commit 6d0405d. as it breaks the elixir test cases
JakobLichterfeld pushed a commit that referenced this pull request Feb 9, 2024
@brianmay @JakobLichterfeld
Add charging_state to VehicleSummary (#3087)
c689e0a 
Fixes: #3078
JakobLichterfeld added a commit that referenced this pull request Feb 9, 2024
@JakobLichterfeld
Revert "Add charging_state to VehicleSummary (#3087)" (#3468)
f9c6537 
This reverts commit 6d0405d. as it breaks the elixir test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobLichterfeld JakobLichterfeld JakobLichterfeld approved these changes

Assignees

@brianmay brianmay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should send mqtt message if charger connected but no power
3 participants
@brianmay @JakobLichterfeld @DrMichael