-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: limit positions to set elevation for to last 10 days #4228
perf: limit positions to set elevation for to last 10 days #4228
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a7bc48d
to
1c4860a
Compare
need support on this one - maybe someone with elixir knowledge can step in? |
@brianmay Can you take a look into this PR? Would love to include this in next release as it greatly improve background performance on small hosts with large logging base. |
c6d6bf2
to
7215b6a
Compare
@JakobLichterfeld did it ! ✌️also having a local dev env now... this is ready. Before you are releasing a new version - do you want to add a hint to the release mentioning availability of postgres 17 and also recommend users checking their current indexes by linking to an issue / discussion? 1.) Upgrade TeslaMate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this correctly, the one tradeoff with this is if I can't run teslamate for some reason (e.g. hardware failure) for 10+ days, the elevations of the last drives may not be set.
Probably a reasonable tradeoff.
true, but in this case you won't have any new data collected. so the potential case would be, hardware failure while driving and then maybe some elevation data updates missing. but in that case you're missing more than just that... think it's ok |
7215b6a
to
4d59544
Compare
Awesome! Love to see it!
Yeah, debating the best way to do it, perhaps including the index checker in the docs as well, but every additional script is a potential source of unrelated support issues.
From what I get, the updated restore doc does not harm if used with postgres16 or before, innit? |
Agree - would like to avoid having it in the docs but maybe give a hint to users that we had cases and asking them to check their instance once in the release notes pointing to the issue?
Agree |
4d59544
to
be38045
Compare
@JakobLichterfeld - rebased on latest master. should be ready for merge. |
This limits the positions to set elevation for to the last 10 days greatly speeding up the query and reducing stress on the database.
fixes #4225