perf: fix skipping streaming data #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
4x query improvement here - should be larger impact on slow hw. @JakobLichterfeld |
|
@JakobLichterfeld - data required for calculation is available in drives -> so: use drives instead of positions for another 60x runtime improvement (totalling to 240x on my instance) ;) |
JakobLichterfeld
added
enhancement
JakobLichterfeld
approved these changes
Oct 10, 2024
JakobLichterfeld
changed the title
swiffer
force-pushed
the
perf-fix-skipping-streaming-data
branch
from
e78bfec
to
aef21ee
Compare
swiffer
force-pushed
the
perf-fix-skipping-streaming-data
branch
from
aef21ee
to
f4fd426
Compare
|
Successfully tested. It is now nearly instant, more than 240x on Rpi 3B+ :-) Thanks so much! |
JakobLichterfeld
merged commit 2b36bad
into
teslamate-org:master
18 of 22 checks passed
JakobLichterfeld
pushed a commit
that referenced
this pull request
Oct 19, 2024
* perf-fix-skipping-streaming-data * use drives instead of positions for another 60x improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4251 - positions table grows over time by the amount of data collected by streaming data. to exclude streaming data we are making use of the a new index (part of the upcoming release). when testing please make sure you are having latest migrations of master branch applied.