Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer rely on this repos tags to match tesseract tags for docker #396

Closed

Conversation

marrts
Copy link
Contributor

@marrts marrts commented Apr 5, 2024

Per discussion here

@marrts
Copy link
Contributor Author

marrts commented Apr 5, 2024

The plan will be to continue this forward for each subsequent tesseract repo. So tesseract planning would have the new step like this:

 - name: Set TAG environment variable
        run: |
          # Check if the current workflow run was triggered by a tag.
          if [[ "${{ github.ref_type }}" == "tag" ]]; then
            # If it's a tag event, set the TAG to the latest tagged version of trajopt
            echo "TAG=${{ matrix.distro }}-0.7" >> $GITHUB_ENV
          else
            # If it's not a tag event (e.g., a push to a branch or a PR), set the TAG to distro-master.
            echo "TAG=${{ matrix.distro }}-master" >> $GITHUB_ENV
          fi

And then this would eventually address this issue because we can specify master and don't have to worry about primary branch names matching across repos.

@Levi-Armstrong
Copy link
Contributor

Since tesseract is a dependent I would prefer going forward that this have the same tag as the rest of the tesseract repos for the same reason we decided for those repos.

@marrts
Copy link
Contributor Author

marrts commented Apr 8, 2024

Since tesseract is a dependent I would prefer going forward that this have the same tag as the rest of the tesseract repos for the same reason we decided for those repos.

Should we also change tesseract_qt main to be master to keep consistency then? And keep main but mark it as deprecated? Then we could simplify this docker tag issue to just match tags all the way through.

@marrts marrts mentioned this pull request Apr 8, 2024
@Levi-Armstrong
Copy link
Contributor

That is fine with me.

@Levi-Armstrong
Copy link
Contributor

I renamed tesseract_qt branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants