Throw the new DockerUnavailableException
when Docker is not available
#1308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request introduces a new
DockerUnavailableException
which is thrown instead ofArgumentException
which was not the appropriate exception to throw since the root of the problem is not a bad argument but the state of the system which is wrong.The exception message has also been slightly improved.
Why is it important?
Unlike
ArgumentException
,DockerUnavailableException
can be caught handled.Related issues
Once both this pull request and #1263 are merged, the error messages will be improved, giving a better hint to the user at what went wrong. Here are two sample messages from the new
DockerUnavailableException
.Running Testcontainers after quitting Docker Desktop:
Running Testcontainers after quitting OrbStack:
How to test this PR
Quit Docker Desktop or configure a bad endpoint then try to run a container. Observe the improved exception and error message.