Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for userns remapping #2594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jan-walther
Copy link

What does this PR do?

This PR adds the configuration values ryuk.userns / TESTCONTAINERS_RYUK_USER_NS, which will cause the ryuk container to run in the host user namespace instead of the default one. This is required because Ryuk mounts the Docker socket into the container and if this isn't done it will receive a permission denied error when trying to access it.

Why is it important?

Enable scenarios where the user namespace has been remapped.

Related issues

N/A

How to test this PR

Automatically testing this change is difficult because it requires changing the dockerd configuration.

@jan-walther jan-walther requested a review from a team as a code owner June 18, 2024 11:53
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 12ae124
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66717520364d8d00087da64e
😎 Deploy Preview https://deploy-preview-2594--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member

Hi @jan-walther thanks for submitting this PR. We are discussing about it internally and in the meantime we'd like to know more about your use case, like in which situations you remap the userns, so we can have a much better understanding in problem space.

Thanks in advance!

@jan-walther
Copy link
Author

Hi, sorry for the late reply! We're running multiple Docker daemons on a single machine which requires us to use --userns-remap.

@mdelapenya
Copy link
Member

I'd like to summon @thaJeztah for a better understanding of userns remapping 🙏

@scorpionknifes
Copy link

Any updates on this 🙏 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants