feat: copy from host to container #2782
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
force-pushed
the
feat/copy-host-path-to
branch
6 times, most recently
from
3f6c23d
to
edb9d04
Compare
Add CopyHostPathTo to container methods, which is capable of copying files and directories from the host to a container. It identifies the correct copy semantics based on inspecting the source and target, replicating the behaviour of docker cp and other OS copy tools. This deprecates CopyDirToContainer and CopyFileToContainer while still correcting their behaviour to also match docker cp behaviour. Replace nonamedreturns linter with nakedret, as nonamedreturns prevents naming returned parameters which has a number of valid uses including: disambiguating return values and error checking. Copying files to the container now doesn't compression as this is slower and consumes more resources for the typical local transfer case. Fix docker copy tests to they validate the correct behaviour by ensuring that done is reported to the container log. Clean up some error wrapping. Fix testdata wait scripts. Fix invalid FileMode values, so tests don't fail with the new FileMode validation. Switch to exists check for copy instead of running it as a shell. Disable linter check for deprecated methods as we use them internally and test them. Fixes #2780
stevenh
force-pushed
the
feat/copy-host-path-to
branch
from
edb9d04
to
2c6196f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CopyHostPathTo to container methods, which is capable of copying files and directories from the host to a container. It identifies the correct copy semantics based on inspecting the source and target, replicating the behaviour of docker cp and other OS copy tools.
This deprecates CopyDirToContainer and CopyFileToContainer while still correcting their behaviour to also match docker cp behaviour.
Replace nonamedreturns linter with nakedret, as nonamedreturns prevents naming returned parameters which has a number of valid uses including: disambiguating return values and error checking.
Copying files to the container now doesn't compression as this is slower and consumes more resources for the typical local transfer case.
Fix docker copy tests to they validate the correct behaviour by ensuring that done is reported to the container log.
Clean up some error wrapping.
Fixes #2780