Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type of wrapper property in RenderOptions #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zetaraku
Copy link

What:

The type of wrapper property in RenderOptions is mistyped, causing the children prop to be inferred as any.

Screenshot

Why:

The wrapper property should be a component instead of an element, just like that in RenderHookOptions.

How:

The type of wrapper property in RenderOptions is changed from ComponentChild to ComponentType<{ children: Element }>.

Checklist:

  • Documentation added N/A
  • Tests N/A
  • Typescript definitions updated
  • Ready to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant