Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useTrackRenders should be usable inside of wrappers #8

Closed
wants to merge 2 commits into from
Closed

fix: useTrackRenders should be usable inside of wrappers #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c1378
fix: `useTrackRenders` should be usable inside of wrappers
phryneas Nov 7, 2024
58adfb8
also update `pkg-pr-new` for better build previews
phryneas Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"concurrently": "^9.0.1",
"expect": "^29.7.0",
"kcd-scripts": "^16.0.0",
"pkg-pr-new": "^0.0.29",
"pkg-pr-new": "^0.0.30",
"prettier": "^3.3.3",
"publint": "^0.2.11",
"react": "^18.3.1",
Expand Down
6 changes: 3 additions & 3 deletions src/renderStream/createRenderStream.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,9 @@ export function createRenderStream<
wrapper: props => {
const ParentWrapper = options?.wrapper ?? React.Fragment
return (
<ParentWrapper>
<Wrapper>{props.children}</Wrapper>
</ParentWrapper>
<Wrapper>
<ParentWrapper>{props.children}</ParentWrapper>
</Wrapper>
)
},
})
Expand Down
46 changes: 29 additions & 17 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,7 +2631,7 @@ __metadata:
expect: "npm:^29.7.0"
jsdom: "npm:^25.0.1"
kcd-scripts: "npm:^16.0.0"
pkg-pr-new: "npm:^0.0.29"
pkg-pr-new: "npm:^0.0.30"
prettier: "npm:^3.3.3"
publint: "npm:^0.2.11"
react: "npm:^18.3.1"
Expand Down Expand Up @@ -5585,7 +5585,7 @@ __metadata:
languageName: node
linkType: hard

"fdir@npm:^6.3.0, fdir@npm:^6.4.0":
"fdir@npm:^6.4.0":
version: 6.4.0
resolution: "fdir@npm:6.4.0"
peerDependencies:
Expand All @@ -5597,6 +5597,18 @@ __metadata:
languageName: node
linkType: hard

"fdir@npm:^6.4.2":
version: 6.4.2
resolution: "fdir@npm:6.4.2"
peerDependencies:
picomatch: ^3 || ^4
peerDependenciesMeta:
picomatch:
optional: true
checksum: 10c0/34829886f34a3ca4170eca7c7180ec4de51a3abb4d380344063c0ae2e289b11d2ba8b724afee974598c83027fea363ff598caf2b51bc4e6b1e0d8b80cc530573
languageName: node
linkType: hard

"fflate@npm:^0.8.2":
version: 0.8.2
resolution: "fflate@npm:0.8.2"
Expand Down Expand Up @@ -8927,9 +8939,9 @@ __metadata:
languageName: node
linkType: hard

"pkg-pr-new@npm:^0.0.29":
version: 0.0.29
resolution: "pkg-pr-new@npm:0.0.29"
"pkg-pr-new@npm:^0.0.30":
version: 0.0.30
resolution: "pkg-pr-new@npm:0.0.30"
dependencies:
"@jsdevtools/ez-spawn": "npm:^3.0.4"
"@octokit/action": "npm:^6.1.0"
Expand All @@ -8938,10 +8950,10 @@ __metadata:
package-manager-detector: "npm:^0.1.2"
pkg-types: "npm:^1.1.1"
query-registry: "npm:^3.0.1"
tinyglobby: "npm:0.2.6"
tinyglobby: "npm:^0.2.9"
bin:
pkg-pr-new: bin/cli.js
checksum: 10c0/e270e29750ca877f8e6c211aee485a41fbbd1b2df0a6cc30f364ac012f81d2a6985215d0a305271bbb0aa770db1390960fbb09a7dd276876125c7193a3b69437
checksum: 10c0/754cde6d51bcf50d8359e93cc7e45924578d19d86dd439ff438a874a22a9a1765034bfe225324a5a96b5f45dc32c0e4f73d6c7e2241b7a809f4b9a074829c8de
languageName: node
linkType: hard

Expand Down Expand Up @@ -10391,16 +10403,6 @@ __metadata:
languageName: node
linkType: hard

"tinyglobby@npm:0.2.6":
version: 0.2.6
resolution: "tinyglobby@npm:0.2.6"
dependencies:
fdir: "npm:^6.3.0"
picomatch: "npm:^4.0.2"
checksum: 10c0/d7b5eb4c5b9c341f961c1d3c30624f9a1e22b27b48a79a65b48120245a77c143827f75f5854628fef1a4bd4bc3cfaf06ce76497f3a574e3f933229c5e556e5fe
languageName: node
linkType: hard

"tinyglobby@npm:^0.2.1":
version: 0.2.9
resolution: "tinyglobby@npm:0.2.9"
Expand All @@ -10411,6 +10413,16 @@ __metadata:
languageName: node
linkType: hard

"tinyglobby@npm:^0.2.9":
version: 0.2.10
resolution: "tinyglobby@npm:0.2.10"
dependencies:
fdir: "npm:^6.4.2"
picomatch: "npm:^4.0.2"
checksum: 10c0/ce946135d39b8c0e394e488ad59f4092e8c4ecd675ef1bcd4585c47de1b325e61ec6adfbfbe20c3c2bfa6fd674c5b06de2a2e65c433f752ae170aff11793e5ef
languageName: node
linkType: hard

"tldts-core@npm:^6.1.50":
version: 6.1.50
resolution: "tldts-core@npm:6.1.50"
Expand Down