Skip to content

Commit

Permalink
test: Run with relevant React stable types
Browse files Browse the repository at this point in the history
This has no effect right now.
Once React 19 is out, we're running tests in both 18 and 19.
The types should match that dimension.

Ideally, we'd be able to test RC types but npm claims `npm install @types/react@npm:types-react@rc` is an invalid comparator.
Putting that in the package.json works but I'm too lazy to write a dedicated script right now.
  • Loading branch information
eps1lon committed Aug 28, 2024
1 parent 7a28fa9 commit 88abd93
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ jobs:
- name: ⚛️ Setup react
run: npm install react@${{ matrix.react }} react-dom@${{ matrix.react }}

- name: ⚛️ Setup react types
if: ${{ matrix.react != 'canary' && matrix.react != 'experimental' }}
run:
npm install @types/react@${{ matrix.react }} @types/react-dom@${{
matrix.react }}

- name: ▶️ Run validate script
run: npm run validate

Expand Down

0 comments on commit 88abd93

Please sign in to comment.