Changes needed for TestNG to work for OpenJDK tests

[shurymury]

With Jigsaw, some tests need to be executed with only java.base module present. Some of the OpenJDK tests use TestNG.

This change includes minimal fixes to allow those tests to work.

[missedone]

the remote package was moved to https://github.com/testng-team/testng-remote in PR #953
is there any special reason you added it back?

[shurymury]

Ugh, sorry.

Lemme fix that.

[shurymury]

I have reverted the un-intentional changes. My apologies.

I do, however, see that now JDK tests are failing with java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException - as of now I do not know the reason.
My hack applied to some older version of TestNG worked fine.

[juherr]

👍 For the PR. Could you just update the CHANGES file to warn about the api change?

About your issue, are you running the tests with IntelliJ? Someone else has the same problem: http://stackoverflow.com/questions/36443730/java-lang-noclassdeffounderror-though-testng-is-not-imported

[shurymury]

1. on java.lang.NoClassDefFoundError: com/beust/jcommander/ParameterException:
   
   I have, for now, added jcommander classes into the testng.jar which lives in the jtreg.home/lib. OpenJDK tests work for me right now. That is a separate issue.
   
2. no - I am not running with IDEA.
   
   The only way I know to reproduce the original problem is to run some of the OpenJDK tests such as:
   
   jtreg.home/bin/jtreg -jdk:jdk9.home -javaoptions:"-limitmods java.base,java.management" java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java
   
   You have to use a JDK built from sources after jigsaw integration:
   http://hg.openjdk.java.net/jdk9/jdk9/rev/f900d5afd9c8
   
   If I run that without my hack, it is failing with
   java.lang.NoClassDefFoundError: org/xml/sax/SAXException
   
3. on changing the CHANGES
   
   Am I supposed to do that manually?

[juherr]

1. Ok, maybe a dependency issue.
2. Ok
3. Yes

[cbeust]

This ClassNotFoundException is weird, I verified that JCommander is listed as a compile dependency in both build.gradle and Build.kt.

[shurymury]

I have updated the repo with an extra line in CHANGES.txt. Did that on Fri, I think.

What would happen next?

Shura

On Apr 6, 2016, at 6:18 AM, Julien Herr [email protected] wrote:

Ok, maybe a dependency issue.
Ok
Yes
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #1018 (comment)

[juherr]

👍

Next step: waiting @cbeust approval and the merge :)

[cbeust]

Looks like we're down to just the removal of initLogger. Since this builds, I'm guessing TestNG doesn't use it and since it's in internals, I guess we're fine.

Merging!

[cbeust]

Next step for you @shurymury: use the TestNG SNAPSHOT to confirm you no longer need your custom version.