Fix Config invocation order for inheritance #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juherr
approved these changes
Mar 28, 2021
3 tasks
| * @param xmlTest - The {@link XmlTest} that represents the current <code>test</code> | ||
| * @return - <code>true</code> if group based selection was employed and false otherwise. | ||
| */ | ||
| public static boolean isGroupBasedExecution(XmlTest xmlTest) { |
There was a problem hiding this comment.
why static? why XmlTest as argument?
why not just xmlTest.isGroupBasedExecution()?
There was a problem hiding this comment.
@martinaldrin - Any specific reasons behind adding comments on a PR that is already merged ?
There was a problem hiding this comment.
I just saw it when I tried to figure out the bug that I found in #2664
Comment on lines
-292
to
306
| String[] groupsDependedUpon = m.getGroupsDependedUpon(); | ||
| if (groupsDependedUpon.length > 0) { | ||
| for (String group : groupsDependedUpon) { | ||
| ITestNGMethod[] methodsThatBelongToGroup = | ||
| MethodGroupsHelper.findMethodsThatBelongToGroup(m, methods, group); | ||
| predecessors.addAll(Arrays.asList(methodsThatBelongToGroup)); | ||
| if (XmlTest.isGroupBasedExecution(xmlTest)) { | ||
| String[] groupsDependedUpon = m.getGroupsDependedUpon(); | ||
| if (groupsDependedUpon.length > 0) { | ||
| for (String group : groupsDependedUpon) { | ||
| ITestNGMethod[] methodsThatBelongToGroup = | ||
| MethodGroupsHelper.findMethodsThatBelongToGroup(m, methods, group); | ||
| predecessors.addAll(Arrays.asList(methodsThatBelongToGroup)); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I guess this is the reason why dependsOnGroup and dependsOnMethods is broken in #2664
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2489
Fixes #2489
Did you remember to?
CHANGES.txtWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.