Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEG parsers' "comment" rule #124

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Fix PEG parsers' "comment" rule #124

merged 1 commit into from
Jan 5, 2024

Conversation

smurfix
Copy link
Contributor

@smurfix smurfix commented Jan 4, 2024

The problem with the previous version was that if there is no text after the '//', regular whitespace processing kicked in and the regexp was applied to the next non-empty line.

The effect of this was that the next line gets commented off unconditionally, which is kindof not what you want.

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

The problem with the previous version was that if there is no text after
the '//', regular whitespace processing kicked in and the regexp was
applied to the next non-empty line.

The effect of this was that the next line gets commented off
unconditionally, which is kindof not what you want.
@igordejanovic igordejanovic merged commit cd76a4c into textX:master Jan 5, 2024
7 checks passed
@igordejanovic
Copy link
Member

Looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants