Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch a completed slice when marking a burrow for liquidation #155

Open
gkaracha opened this issue Jun 9, 2021 · 0 comments · May be fixed by #240
Open

Touch a completed slice when marking a burrow for liquidation #155

gkaracha opened this issue Jun 9, 2021 · 0 comments · May be fixed by #240
Labels
design Discussion about the design of a feature enhancement New feature or request

Comments

@gkaracha
Copy link
Contributor

gkaracha commented Jun 9, 2021

As we have discussed at some point in the past, it might be a good idea to make entrypoint_mark_for_liquidation trigger the garbage collection of a slice from a completed auction. In degenerate cases the liquidation queue can still grow faster than is garbage collected of course, but in many cases this extension would help average out the number of slices being sent to auctions.

Of course this change would increase the size of and gas costs for entrypoint_mark_for_liquidation but I think that this might be OK (as of the writing this issue entrypoint_mark_for_liquidation is ~18321 bytes).

@gkaracha gkaracha added enhancement New feature or request design Discussion about the design of a feature labels Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Discussion about the design of a feature enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant