-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch the oldest completed slice when marking a burrow for liquidation #240
Draft
gkaracha
wants to merge
25
commits into
master
Choose a base branch
from
gkaracha/touch-when-marking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkaracha
force-pushed
the
gkaracha/touch-when-marking
branch
3 times, most recently
from
August 17, 2021 11:35
77d595c
to
25d5979
Compare
gkaracha
force-pushed
the
gkaracha/touch-when-marking
branch
from
August 19, 2021 12:20
25d5979
to
7f5ea12
Compare
Sidenote: experiment of the |
3 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155.
I am opening this as a draft PR already so that it's easier to evaluate the gas cost differences.
By looking at this I realized that we have quite some code duplication around touching liquidation slices.
touch_liquidation_slice
is the function processing a single slice, but then we havetouch_oldest
that touches the oldestConstants.number_of_slices_to_process
completed slices,touch_liquidation_slices_rec
that touches a list of completed slices passed as an argument, and nowentrypoint_mark_for_liquidation
also finds the oldest completed slice and then touches it.I am thinking that perhaps this is a good time to restructure the code a little to reduce duplication, as part of this PR. If we implement
find_oldest_slices : Ligo.nat -> liquidation_auctions -> leaf_ptr list
, then (1) and (3) can be simplified quite some:touch_oldest
can be rewritten (inlined, really) astouch_liquidation_slices_rec (find_oldest_slices Constants.number_of_slices_to_process auctions)
, andentrypoint_mark_for_liquidation
can now also simply calltouch_liquidation_slices_rec (find_oldest_slices 1 auctions)
.I'll have a go and see if gas costs allow for these changes.