-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial stress test for liquidation auction #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👌 I left a few suggestions but apart from the one relating to the potentially failing assertion the rest could be done later as well. It's great to finally have a liquidation test, thanks! 😄
# The return value is supposed to be annotated as "auction_id" and "minimum_bid", I | ||
# do not know why we get these names. I think there is an underlying pytezos bug | ||
# that we should reproduce and create a bug upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, that's weird indeed 🤔 Not sure if it's a pytezos bug; it reminds me of #81.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just a couple of small comments but otherwise LGTM as well. It would be cool to add some profiling in this test so that we can see the trend in gas costs with successive calls. I'm happy to work on that next week as a separate PR though.
This PR adds a new e2e test called
LiquidationsStressTest
which creates a thousand liquidation slices.It mainly tests the
push_back
function, and it seems to be well below the gas limit since we're triggering 40 liquidations as a bulk operation. We should add similar tests for other AVL functions too (split
anddel
comes to mind).While doing that, I had to implement a few other minor changes:
When we end up in a state where our E2E tests run reliably, we should add this to the CI.