-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paris support - fix #703 #704
Merged
Merged
Commits on Jun 3, 2024
-
Bare Minimum Barely tested code for now. * look at `delegatedBalance` instead of `balance` in the TzKT API query results * do not include bakers' fees as reward as discussed in issue
Configuration menu - View commit details
-
Copy full SHA for 16d6147 - Browse repository at this point
Copy the full SHA 16d6147View commit details
Commits on Jun 4, 2024
-
fixes after reading tzkt documentation
delegatedBalance is deprecated, need to sum up `own` and `external` instead also made a note that `currentDelegatedBalance` of delegators is also deprecated
Configuration menu - View commit details
-
Copy full SHA for e12e343 - Browse repository at this point
Copy the full SHA e12e343View commit details
Commits on Jun 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1cf9e3c - Browse repository at this point
Copy the full SHA 1cf9e3cView commit details
Commits on Jun 26, 2024
-
modify the Reward model to pass own + external delegated
TzKT offers own_delegated and external_delegated values. We pass them both to the reward calculation function. OWNER_PARENT is the baker's reward. It's named this way because it can split into children rewards when the bakery has several "owners" and "founders" (maybe we should also deprecate this functionality). Now, we populate this value straight from tzkt. We also use it to calculate the ratio. There is a sanity function that ensures that the sum of itemized balances and the total from tzkt are "almost equal". This apparently is still passing. With these changes, I see more realistic values in my caculations: values are lower than with main branch, which makes sense, because the stake has now increased. Also, for my baker, almost all balance is staked, so I only keep an amount of delegation rewards approx. equal to my delegation fee. In contrast, before AI, I would keep my fee plus my own rewards, which now go almost exclusively to the staking balance.
Configuration menu - View commit details
-
Copy full SHA for f4381e0 - Browse repository at this point
Copy the full SHA f4381e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e59753 - Browse repository at this point
Copy the full SHA 4e59753View commit details -
Configuration menu - View commit details
-
Copy full SHA for 790acbb - Browse repository at this point
Copy the full SHA 790acbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a57dbe5 - Browse repository at this point
Copy the full SHA a57dbe5View commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78d6576 - Browse repository at this point
Copy the full SHA 78d6576View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e0c67d - Browse repository at this point
Copy the full SHA 0e0c67dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24113d6 - Browse repository at this point
Copy the full SHA 24113d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76a1268 - Browse repository at this point
Copy the full SHA 76a1268View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c0ffa9 - Browse repository at this point
Copy the full SHA 6c0ffa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaad513 - Browse repository at this point
Copy the full SHA eaad513View commit details
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c9e3882 - Browse repository at this point
Copy the full SHA c9e3882View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.