Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set new protocol date, do not confirm when passed, fix #701 #705

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

nicolasochem
Copy link
Contributor


name: Pull Request
about: Create a pull request to make a contribution
labels:


IMPORTANT NOTICE:
I read and understood the guidelines for contributions to the TRD. The contribution may qualify for being compensated by the TRD grant if approved by the maintainers.

This PR resolves the issue . The following steps were performed:

  • Analysis: If the described issue is a bug report, analyze the reasons resulting in this bug.

  • Solution: Describe the proposed solution for the bug or feature.

  • Implementation: Rough description/explanation of the implementation choices.

  • Performed tests: Describe the performed tests.

  • Documentation: Make sure to document the added changes in a proper way (Readme, help section, documentation, comments in code if needed)

  • Check list:

  • I extended the Github Actions CI test units with the corresponding tests for this new feature (if needed).
  • I extended the Sphinx documentation (if needed).
  • I extended the help section (if needed).
  • I changed the README file (if needed).
  • I created a new issue if there is further work left to be done (if needed).

Work effort: Give your estimate of the work effort in hours. This might be adjusted or discussed by the other contributors in order to keep a fair rewarding process for the efforts.

@nicolasochem nicolasochem merged commit 0a666c3 into master Jun 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant