Better slicing #1059
Merged
Better slicing #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanndupis
reviewed
Apr 26, 2022
yanndupis
reviewed
Apr 26, 2022
yanndupis
reviewed
Apr 27, 2022
yanndupis
reviewed
Apr 27, 2022
Comment on lines
+76
to
+77
| (HostPlacement, (Shape) -> Shape => [concrete] Self::logical_host_shape), | ||
| (HostPlacement, (Tensor) -> Tensor => [concrete] Self::logical_host_kernel), |
There was a problem hiding this comment.
nit: we often put the the logical kernel at the top for each placement (e.g identity)
There was a problem hiding this comment.
I was thinking about this and how we should sort kernel types, I thought it would be good if we sort them by kernel types (whether they're runtime / replicated protocols / lowering) and then we sort everything alphabetically after the input types, something similar as @jvmncs did in a previous PR. I couldn't find something better for now.
yanndupis
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1064
Does a few things:
BitArray. See BitArray slicing #1066ConstantOp.