add allauth middleware to test settings #1090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The django-allauth package since 0.56¹ requires setting up its middleware in settings. The same issue² was fixed in dj-rest-auth 5.0.2. [1] https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst#backwards-incompatible-changes-1 [2] iMerica/dj-rest-auth#561
mweinelt
force-pushed
the
allauth-middleware
branch
from
8db4c24
to
c9d2f89
Compare
|
The django-allauth package dropped support for Python 3.6 in 0.54.0 released in 2023/03. https://github.com/tfranzel/drf-spectacular/actions/runs/6613694377/job/18824130191?pr=1090 |
Python 3.6 is not supported by django-allauth>=0.54.0, which is now the below the minimum required version.
|
So generally I would be willing to drop py3.6 from testing, but that seems not the only problem here. I was unable to quickly come up with a combination of |
|
Yeah, I failed at that step, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The django-allauth package since 0.56¹ requires setting up its middleware in settings.
Note that a PR² for dj-rest-auth is open to solve the situation there as well and merging should probably wait until they publish a new release.
[1] https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst#backwards-incompatible-changes-1
[2] iMerica/dj-rest-auth#561