No extra items in the oneOf list

[DopustimVladimir]

In case we want to map some different values to the same serializer:

class XViewSet(viewsets.GenericViewSet):
    @extend_schema(
        responses=PolymorphicProxySerializer(
            component_name='MetaPerson',
            serializers={
                'natural': NaturalPersonSerializer,
                'basic': DefaultPersonSerializer,
                'simple': DefaultPersonSerializer,
            },
            resource_type_field_name='type',
        )
    )

We don't need extra items in the oneOf section like here:

components:
  schemas:
    MetaPerson:
      oneOf:
      - $ref: '#/components/schemas/NaturalPerson'
      - $ref: '#/components/schemas/DefaultPerson'
      - $ref: '#/components/schemas/DefaultPerson' # extra item
      discriminator:
        propertyName: type
        mapping:
          natural: '#/components/schemas/NaturalPerson'
          basic: '#/components/schemas/DefaultPerson'
          simple: '#/components/schemas/DefaultPerson'

The expected result is:

components:
  schemas:
    MetaPerson:
      oneOf:
      - $ref: '#/components/schemas/NaturalPerson'
      - $ref: '#/components/schemas/DefaultPerson'
      discriminator:
        propertyName: type
        mapping:
          natural: '#/components/schemas/NaturalPerson'
          basic: '#/components/schemas/DefaultPerson'
          simple: '#/components/schemas/DefaultPerson'

[tfranzel]

Hey @DopustimVladimir,

nice catch. This is of course results in a cleaner schema. I'm just wondering where the duplication became a problem?

[DopustimVladimir]

Hey @DopustimVladimir,

nice catch. This is of course results in a cleaner schema. I'm just wondering where the duplication became a problem?

Oh, actually I can't really call it a problem but Orval takes it as is and gives out weird things like:

export type MetaPerson = NaturalPerson | DefaultPerson | DefaultPerson;

Expected result is:

export type MetaPerson = NaturalPerson | DefaultPerson;