Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix django-mongoengine support #974

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

last-partizan
Copy link

@tfranzel Hi, this refactors one particular bugfix: 21068e0

I put this code into _map_model_field, becouse that fix has broken my previous fix: overriding _map_model_field to support django-mongoengine field types (MongoEngine/django-mongoengine@2ef9529).

This way it should work fine for both cases.

Refs #200

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (4387fed) 98.62% compared to head (f585c11) 98.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   98.62%   98.61%   -0.02%     
==========================================
  Files          68       68              
  Lines        8245     8245              
==========================================
- Hits         8132     8131       -1     
- Misses        113      114       +1     
Impacted Files Coverage Δ
drf_spectacular/openapi.py 97.33% <66.66%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant