Skip to content

Commit

Permalink
breaking ⚠️ GCS,S3,BOS: Remove thanos- prefix from the user agent
Browse files Browse the repository at this point in the history
Signed-off-by: ohkinozomu <[email protected]>
  • Loading branch information
ohkinozomu committed Nov 13, 2023
1 parent 37752ee commit 653dc5a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,5 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#65](https://github.com/thanos-io/objstore/pull/65) *: Upgrade minio-go version to `v7.0.61`.
- [#70](https://github.com/thanos-io/objstore/pull/70) GCS: Update cloud.google.com/go/storage version to `v1.27.0`.
- [#71](https://github.com/thanos-io/objstore/pull/71) Replace method `IsCustomerManagedKeyError` for a more generic `IsAccessDeniedErr` on the bucket interface.
- [#88](https://github.com/thanos-io/objstore/pull/88) breaking :warning: GCS,S3,BOS: Remove thanos- prefix from the user agent
### Removed
2 changes: 1 addition & 1 deletion providers/bos/bos.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func NewBucketWithConfig(logger log.Logger, config Config, component string) (*B
return nil, errors.Wrap(err, "creating BOS client")
}

client.Config.UserAgent = fmt.Sprintf("thanos-%s", component)
client.Config.UserAgent = component

bkt := &Bucket{
logger: logger,
Expand Down
2 changes: 1 addition & 1 deletion providers/gcs/gcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func NewBucketWithConfig(ctx context.Context, logger log.Logger, gc Config, comp
}

opts = append(opts,
option.WithUserAgent(fmt.Sprintf("thanos-%s/%s (%s)", component, version.Version, runtime.Version())),
option.WithUserAgent(fmt.Sprintf("%s/%s (%s)", component, version.Version, runtime.Version())),
)

gcsClient, err := storage.NewClient(ctx, opts...)
Expand Down
2 changes: 1 addition & 1 deletion providers/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func NewBucketWithConfig(logger log.Logger, config Config, component string) (*B
if err != nil {
return nil, errors.Wrap(err, "initialize s3 client")
}
client.SetAppInfo(fmt.Sprintf("thanos-%s", component), fmt.Sprintf("%s (%s)", version.Version, runtime.Version()))
client.SetAppInfo(component, fmt.Sprintf("%s (%s)", version.Version, runtime.Version()))

var sse encrypt.ServerSide
if config.SSEConfig.Type != "" {
Expand Down

0 comments on commit 653dc5a

Please sign in to comment.