Only register fetched_bytes metrics for Get/GetRange #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20230727_only-register-fetched-bytes-get-getrange
branch
from
662f306 to
4e6bf23
Compare
The other operations are not exposing the fetched bytes. Signed-off-by: Christian Simon <[email protected]>
simonswine
force-pushed
the
20230727_only-register-fetched-bytes-get-getrange
branch
from
4e6bf23 to
25a6c5a
Compare
matej-g
reviewed
Aug 3, 2023
Comment on lines
+459
to
+462
| for _, op := range []string{ | ||
| OpGet, | ||
| OpGetRange, | ||
| } { |
There was a problem hiding this comment.
Should we simply put this into the other loop below with transferred bytes or do we need the extra loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other operations are not exposing the fetched bytes.