Update google storage library #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates cloud.google.com/go/storage to 1.35. Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
update-go-storage
branch
3 times, most recently
from
5178dea to
64d52ef
Compare
Signed-off-by: Filip Petkovski <[email protected]>
fpetkovski
force-pushed
the
update-go-storage
branch
from
64d52ef to
16876bc
Compare
Signed-off-by: Filip Petkovski <[email protected]>
GiedriusS
reviewed
Nov 15, 2023
README.md
Outdated
| @@ -88,8 +88,7 @@ type BucketReader interface { | |||
| // IsObjNotFoundErr returns true if error means that object is not found. Relevant to Get operations. | |||
| IsObjNotFoundErr(err error) bool | |||
|
|
|||
| // IsAccessDeniedErr returns true if access to object is denied. | |||
| IsAccessDeniedErr(err error) bool | |||
| // IsAccessDeniedErr returns true if acces to object is denied. | |||
There was a problem hiding this comment.
This seems a bit off - do we need to edit the mdox line above?
There was a problem hiding this comment.
You're right, the method comment had a typo.
Signed-off-by: Filip Petkovski <[email protected]>
|
@GiedriusS any other comments or are we good to merge this? |
Signed-off-by: Filip Petkovski <[email protected]>
saswatamcode
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates cloud.google.com/go/storage to 1.35.
Changes
Upgrade
cloud.google.com/go/storage versionv1.35.1Verification
Unit tests