Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zig httpz server #7945

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Add zig httpz server #7945

merged 9 commits into from
Nov 15, 2024

Conversation

Kayden1412
Copy link
Contributor

No description provided.

Copy link
Collaborator

@waghanza waghanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🎉

Could you specify GitHub location, and any website for httpz?

@Kayden1412
Copy link
Contributor Author

https://github.com/karlseguin/http.zig.

It does not have a website.

@waghanza
Copy link
Collaborator

@karlseguin We are going to introduce httpz here. Is this something you are OK with.

We can ping you (not so often) to make sure the implementation is OK

@waghanza
Copy link
Collaborator

@Kayden1412 could you use https://github.com/ziglang/docker-zig if it is updated?

zig/httpz/src/main.zig Outdated Show resolved Hide resolved
zig/httpz/src/main.zig Outdated Show resolved Hide resolved
@karlseguin
Copy link

Sure.

Current master code is pretty far from 0.13 branch. Maybe when Zig 0.14 is released, we can do an update.

@Kayden1412
Copy link
Contributor Author

Kayden1412 commented Nov 13, 2024

@Kayden1412 could you use https://github.com/ziglang/docker-zig if it is updated?

@waghanza
I use this one instead https://hub.docker.com/r/chainguard/zig

@waghanza
Copy link
Collaborator

waghanza commented Nov 13, 2024

I have not enough worked with zig to know which image suits best.

The idea is to have an image that you are confident with to go in production, at list n image close to this goal

@waghanza
Copy link
Collaborator

I'll add this PR for next round, and monitor zig updates

@waghanza waghanza enabled auto-merge (squash) November 15, 2024 17:16
@waghanza waghanza merged commit ebc1528 into the-benchmarker:master Nov 15, 2024
2 checks passed
@waghanza
Copy link
Collaborator

@karlseguin @Kayden1412 I have

thread 26 panic: reached unreachable code
Panicked during a panic. Aborting.
error: the following build command crashed:
/app/.zig-cache/o/3c97310c79e5fa4f1bb00d7c1d5b2ebe/build /usr/bin/zig /app /app/.zig-cache /root/.cache/zig --seed 0x4dd03a9d -Z48d7c4c12cea8f62 -Doptimize=ReleaseFast

when trying to compile inside a container with zig build -Doptimize=ReleaseFast

maybe something related to arch, we use aarch to produce results (mac m1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants