add phpstan tests as well

the-kbA-team · Mar 20, 2024 · 111b2ea · 111b2ea
1 parent 0100be7
commit 111b2ea
Show file tree

Hide file tree

Showing 4 changed files with 102 additions and 74 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -0,0 +1,8 @@
+parameters:
+  level: 8
+  ignoreErrors:
+    #- message: '#Parameter \#1 \$data of static method kbATeam\\DataProtection\\SecureSearch::encrypt\(\) expects string, int given.#'
+    #  path: tests/SecureSearchTest.php
+  paths:
+    - src/
+    - tests/
diff --git a/src/Log/Engine/GraylogLog.php b/src/Log/Engine/GraylogLog.php
@@ -143,7 +143,7 @@ public function __construct($config = [])
      *
      * @param mixed   $level
      * @param string  $message
-     * @param array $context
+     * @param array<mixed> $context
      *
      * @return void
      *
@@ -259,6 +259,7 @@ protected function createMessage(string $level, string $message): GelfMessage
         /**
          * Create a debug backtrace.
          */
+        $trace = null;
         if ($add_file_and_line || $append_backtrace) {
             $trace = new ClassicBacktrace(
                 $this->getConfig('trace_level_offset'),
@@ -270,7 +271,7 @@ protected function createMessage(string $level, string $message): GelfMessage
          * In case the log didn't happen in memory (like with reflections), add
          * the filename and line to the message.
          */
-        if ($add_file_and_line && $trace->lastStep('file') !== null) {
+        if ($add_file_and_line && is_object($trace) && $trace->lastStep('file') !== null) {
             $gelfMessage->setAdditional('file', $trace->lastStep('file'));
             $gelfMessage->setAdditional('line', $trace->lastStep('line'));
         }
@@ -291,7 +292,7 @@ protected function createMessage(string $level, string $message): GelfMessage
         /**
          * Append backtrace in case it's not already in the message.
          */
-        if ($append_backtrace) {
+        if ($append_backtrace && is_object($trace)) {
             /**
              * Append backtrace to message.
              */
@@ -302,9 +303,13 @@ protected function createMessage(string $level, string $message): GelfMessage
         /**
          * Set function output as additional field.
          */
-        foreach ($this->getConfig('additional', []) as $key => $function) {
-            if (is_callable($function)) {
-                $gelfMessage->setAdditional($key, (string)$function());
+
+        $configStack = $this->getConfig('additional', []);
+        if (is_array($configStack)) {
+            foreach ($configStack as $key => $function) {
+                if (is_callable($function) && is_string($key)) {
+                    $gelfMessage->setAdditional($key, (string)$function());
+                }
             }
         }
 
@@ -321,7 +326,7 @@ protected function createMessage(string $level, string $message): GelfMessage
             return $gelfMessage->setShortMessage($shortMessage);
         }
         return $gelfMessage
-            ->setShortMessage($shortMessage)
+            ->setShortMessage((string)$shortMessage)
             ->setFullMessage($message);
     }
 }