Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snackbar): review and fix issues #7

Merged
merged 5 commits into from
Jan 5, 2025
Merged

fix(snackbar): review and fix issues #7

merged 5 commits into from
Jan 5, 2025

Conversation

njfamirm
Copy link
Member

@njfamirm njfamirm commented Jan 5, 2025

Description

Tasks

  • 📝 Self-Review: Ensure that you have thoroughly reviewed your own code changes.
  • 📚 Code Documentation: Update or create all necessary documentation within the code.
  • 📖 User Guides: Add necessary guides to the help document, including README or other help files (if applicable).
  • 🎨 Formatting: Ensure that the code is properly formatted.
  • 📅 Daily Report: Record the changes in the company's daily report, if applicable.
  • 🔄 Rebase: Ensure your branch is rebased and updated based on the default branch.
  • ⬆️ GitHub Project & Assignee: Ensure this pull request is correctly assigned and added to the appropriate GitHub project with the correct status.
  • Local Deployment Testing (If Applicable): If the changes affect the application's functionality, deploy and test the application locally to ensure it functions as expected.

@njfamirm njfamirm self-assigned this Jan 5, 2025
@Copilot Copilot bot review requested due to automatic review settings January 5, 2025 08:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/snackbar/src/lib/handler.ts:54

  • The function handleActionButtonClick is declared to return a Promise, but it does not actually return a promise. Either update the function to return a promise or change the return type to void.
function handleActionButtonClick(closeSnackbar: () => Promise<void>, handler?: SnackbarActionHandler): Promise<void> {
@njfamirm njfamirm added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jan 5, 2025
@njfamirm njfamirm changed the title Bugfix/subsribe fix(snackbar): review and fix issues Jan 5, 2025
@njfamirm njfamirm requested a review from Copilot January 5, 2025 09:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • package.json: Language not supported
  • packages/snackbar/package.json: Language not supported

packages/snackbar/src/lib/handler.ts Show resolved Hide resolved
@njfamirm njfamirm merged commit 2ac0910 into next Jan 5, 2025
2 checks passed
@njfamirm njfamirm deleted the bugfix/subsribe branch January 5, 2025 09:38
@njfamirm njfamirm requested a review from arashagp January 5, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant