Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Header heights to fit Box content #343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

travisk-codes
Copy link
Contributor

Changes:

  1. Constrains height of the Header component to fit the text content of the Box component (see screenshots)
  2. Fixes [Bug] Top of resource page header text boxes cut off #339

Additional Notes:

  • Probably wanna test on your machine before commit, a lot of positioning changes.
  • Makes subjective design decisions, please offer feedback (e.g. should the Header have a min-height?

Screenshots:
Before:
tph-header-auto-height-1-before
After:
tph-header-auto-height-1-after
Before:
tph-header-auto-height-2-before
After:
tph-header-auto-height-2-after
Before:
tph-header-auto-height-3-before
After:
tph-header-auto-height-3-after
Before:
tph-header-auto-height-4-before
After:
tph-header-auto-height-4-after

@veksen veksen force-pushed the 339-header-auto-height branch from d414787 to a07e0af Compare September 17, 2020 01:00
@veksen
Copy link
Collaborator

veksen commented Sep 17, 2020

So, a lot going on here, there's a few things I'm not happy with, and I'm realizing my intent with the design and layout is not clear. I'm going to sketch out the various layouts and we can discuss the changes needed.

@veksen
Copy link
Collaborator

veksen commented Nov 12, 2020

Sorry, left this for a while, and did a conflicting PR (#376). Let me know if you'd like to go over this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Top of resource page header text boxes cut off
2 participants