Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VIA keymap to keyboard shuguet/shu89 #46

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

shuguet
Copy link

@shuguet shuguet commented Dec 30, 2024

Description

Adding a VIA compatible keymap to my new keyboard currently going through PR acceptance on QMK side.

QMK Pull Request

qmk/qmk_firmware#24758

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • I have tested this keyboard definition with firmware on a device.(MANDATORY)
  • VIA keymap uses custom menus
  • The Vendor ID is not 0xFEED

@shuguet shuguet marked this pull request as draft December 31, 2024 14:14
@shuguet shuguet marked this pull request as ready for review January 3, 2025 08:51
@shuguet
Copy link
Author

shuguet commented Jan 16, 2025

PR has been accepted/merged on QMK side, would appreciate a +1 :)

@Cipulot Cipulot merged commit 4bd7e09 into the-via:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants