-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Tufte-style sidenotes and justified text #338
Conversation
bec4842
to
b94275e
Compare
The sidebar is gone for me in the preview :( |
Is that another instance of #147, just now more visible as the breakpoints have changed again? |
b94275e
to
e691e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice! It's depressing we need to rely on JS at all here, I'm amazed how well it works!
The only problem I've noticed is that footnotes aren't visible when JS is disabled. We could fix it by adding a CSS class to the body from Javascript to enable the footnotes, but I'm not sure either of us can face wrangling the CSS for that, so inclined to say ship it as is :D.
The targets of footnote links (like |
@ncfavier Yeah, it's intentional. Since browsers won't move you to a hash that's not painted, clicking the footnote references on the desktop layout does nothing. But when the screen is narrow and the footnotes render again, the footnote references just work, without us having to shuffle the DOM, or override |
ba092e4
to
fb5b0cd
Compare
Co-authored-by: Naïm Favier <[email protected]>
7bc3532
to
76d6017
Compare
Not much to say here, just gotta wait for the preview to render, I suppose.