Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added (homotopy) Pushouts and Cocones, and some features/examples of said. #418

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

jake-87
Copy link
Contributor

@jake-87 jake-87 commented Jul 27, 2024

Description

Added (homotopy) Pushouts and Cocones, and some features/examples of said.

This PR is almost certainly not perfect - I have tried my best to match the existing code and similar, and likewise have tried my best to write good quality prose, but I'm leaving this a WIP until I'm confident in the quality of work.

In the meantime though, review/critique is much appreciated.

Checklist

Before submitting a merge request, please check the items below:

  • I've read the contributing guidelines.
  • The imports of new modules have been sorted with support/sort-imports.hs (or nix run --experimental-features nix-command -f . sort-imports).
  • All new code blocks have "agda" as their language.

If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with chore:.

@Lavenza
Copy link
Member

Lavenza commented Jul 27, 2024

Pull request preview

@jake-87 jake-87 marked this pull request as ready for review August 2, 2024 02:22
Copy link
Collaborator

@TOTBWF TOTBWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a couple of minor formatting nits :)

src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
@jake-87
Copy link
Contributor Author

jake-87 commented Aug 3, 2024

Sorry about that commit sleugh, I'm happy to squash them if wanted.

src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
src/Homotopy/Pushout.lagda.md Outdated Show resolved Hide resolved
@jake-87
Copy link
Contributor Author

jake-87 commented Aug 3, 2024

Thank you - I'll take that as a general comment that my writing style was too "informal", I suppose? (and to prefer inline latex for complex expressions)

Wren H and others added 2 commits August 3, 2024 21:01
Co-authored-by: Naïm Favier <[email protected]>
@jake-87 jake-87 requested a review from ncfavier August 5, 2024 22:38
@jake-87
Copy link
Contributor Author

jake-87 commented Sep 22, 2024

Hi @ncfavier - is there anything else you'd like me to change?

@ncfavier ncfavier enabled auto-merge (squash) September 23, 2024 09:04
@ncfavier ncfavier merged commit 7d43c4b into the1lab:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants