Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update stackage resolver to lts-22.11 for build compatibility #129

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

ncaq
Copy link
Contributor

@ncaq ncaq commented Feb 21, 2024

Avoided not being registered in stackage due to the following error.

- aws-lambda-haskell-runtime < 0 # tried aws-lambda-haskell-runtime-4.1.2, but its *library* requires the disabled package: safe-exceptions-checked

https://github.com/commercialhaskell/stackage/blob/fb2a50c986c1dab18c5aeef5bf1e12eadcbb37f3/build-constraints.yaml#L6267C1-L6267C156

The safe-exceptions-checked library was deprecated, causing it not to build.
It has an old list of dependencies,
so I tried adding it to extra-deps and found that transformers, etc. require a large number of out-of-stackage-managed dependencies, causing it not to build.
I could not find any other good-looking check-exception library. Having no choice I decided to remove the check exception mechanism itself.

I believe that it should not contain any destructive changes. The removal of the check exception feature changes the type signature, but does not change the behavior,
so it is not broken unintentionally.
It is also sufficient for the user to remove the type signatures if they have been written.

Avoided not being registered in stackage due to the following error.

> ```
> - aws-lambda-haskell-runtime < 0 # tried aws-lambda-haskell-runtime-4.1.2, but its *library* requires the disabled package: safe-exceptions-checked
> ```
>
> <https://github.com/commercialhaskell/stackage/blob/fb2a50c986c1dab18c5aeef5bf1e12eadcbb37f3/build-constraints.yaml#L6267C1-L6267C156>

The [safe-exceptions-checked](https://hackage.haskell.org/package/safe-exceptions-checked) library was deprecated,
causing it not to build.
It has an old list of dependencies,
so I tried adding it to `extra-deps` and found that transformers, etc.
require a large number of out-of-stackage-managed dependencies,
causing it not to build.
I could not find any other good-looking check-exception library.
Having no choice I decided to remove the check exception mechanism itself.

I believe that it should not contain any destructive changes.
The removal of the check exception feature changes the type signature,
but does not change the behavior,
so it is not broken unintentionally.
It is also sufficient for the user to remove the type signatures if they have been written.
@NickSeagull
Copy link
Member

Thanks a lot!

@NickSeagull NickSeagull merged commit 44f1c05 into theam:main Feb 22, 2024
1 check passed
@ncaq ncaq deleted the fix-stackage branch February 24, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants