feat: add support for new architecture in compatibility mode #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
force-pushed
the
@gabrieldonadel/new-arch-support
branch
from
22f391f to
92d4baa
Compare
mikehardy
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Thanks for this @gabrieldonadel ! Looks good on review and appears to work locally
I've done a chunk of work here for QA purposes, to make sure CI can go green and to refresh the example, and things appear to work well at least on a backwards-compatibility check
Note that I have not initialized a react-native 0.74-rc project with new arch enabled to see if this works in bridgeless which is it's purpose, but I assume you've done so or what's the point 😆
mikehardy
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
## [12.2.0](v12.1.5...v12.2.0) (2024-04-10) ### Features * add support for new architecture in compatibility mode ([#505](#505)) ([7fda601](7fda601))
|
🎉 This PR is included in version 12.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Android and iOS support for the new architecture relying on the compatibility layer.
On Android
two main changes were required for this to work:
staticfrom all functions annotated with@ReactMethodgiven that in bridgeless it would throw the following errorOn iOS
Had to create a dedicated class for the RCTFBSDKLoginButton view in order to export the
onChangeview property of typeRCTBubblingEventBlockand declare this property on the UIView wrapping the button (FBSDKLoginButtonis a final class and can't be extended)Test Plan:
Locally run
refresh-exampleto update to the latest RC and tested Android and iOS on the old and new architecturesScreen.Recording.2024-03-25.at.12.41.18.mov
Screen.Recording.2024-03-25.at.12.45.50.mov